Ignoring popularity comparisons (which I still think would go to Aladdin), let’s just compare the visuals you would expect to see.
Aladdin would likely be a flight over and through the desert, the city of Agrabah, into the Cave of Wonders. Likely encounters with an animatronic Genie, and the giant snake Jafar. Super iconic locations and super iconic ride vehicle, being the Magic Carpet. There’s a lot of wish fulfillment possible here that the current spinner doesn’t deliver.
With Moana, you have another boat ride through the tropics (Jungle Cruise and Pirates anyone?) maybe with an encounter of a giant crab. Maybe they play around with that open sea simulator patent…but do we really want to see ANOTHER screen heavy dark ride? Moana is just not as visual interesting or innovative compared to Aladdin.