I would argue that passholders over a course of a year probably spend less than a person who spends 5-7 days and only comes once or twice over a decade.
FYI-Other than my own history I have zero proof to support my theory
I have been a season passholder, and when I was I really only spent money on Dole Whips,churros and Sprite. Maybe a souvenir or two but not much more than that. So my total throughout the course of the year was just a few hundred dollars over what I spent on my pass. Now that the passholder discounts are not much better than Florida resident rates, to me the AP prices just don't seem like a great value. The free parking is nice. But the perks on an AP are few and far between these days. Disney doesn't play the loyal customer game. Even the bounce back offers you get in your room aren't any different than a Florida resident rate. They used to be 45-50% a decade ago. Sadly the term "Used to be" seems to be my phrase of choice when discussing my thoughts and feelings about the World.
I also think Disney wants Floridians to buy these 3-4 day passes that are only good for a small window. This must make the bean counting easier.
I am going on my first Disney Cruise in two weeks so I am hoping that will bring me out of my Disney World doldrums.