Timeshares in general get a bad rap primarily because so many people get duped into buying them without having all the facts or really figuring out if it's a good purchase for them. Timeshare sales people rely on impulse buyers who take a tour to get free stuff and end up buying. When buyers remorse sets in or they figure out they can't afford or won't end up using the timeshare enough, a lot of people sell at a loss if they can even find a buyer. This creates the general opinion that tineshares are not a smart purchase. In a lot of cases they are not, but it's not the timeshare that's not smart it's the owner

. In general if you buy a high quality timeshare, actually use it every year and don't need to sell it you can make out pretty well. Not as a financial investment but as far as getting good value for your vacation dollar.
DVC is actually different because of the resale market and very active rental market. If I decide to take a break from using my DVC for financial reasons or really any reason I can rent my points out for over 2.5 times my maintenance fees and I can go to a broker to do it so no messing with eBay or Craig's list. If I need to get out I can still recover a large portion of what I put down selling via the resale market. It seriously reduces one of the biggest risks of buying a timeshare.