Man, a million things that could be said about all of this...
I grew up getting to go to WDW almost every year, first with my family and then as part of the class trips my parents would chaperone for the high school they worked at. I get to do that latter thing now, and it means getting to go to Disney for next to nothing, given how the price structures go for group/school trips. When that's the case? I can't complain much about Lightning Lanes and food prices or whatever. But I also know that, despite being a lifelong fan with a massive amount of nostalgia for the parks (I'm pushing 40 now), it's not a trip I'm looking to do that frequently anymore unless I'm getting that kind of discount. Maybe a trip for a couple days at Food and Wine with my girlfriend at some point, but not a ton else.
It hurts to say, because there's still tons I love about visiting: I love going through the classics in MK, I'm a lifelong EPCOT nerd, adore AK's theming, I even still get a big kick out of the front half of Studios. But for one, there's not enough to fully justify the costs involved anymore; I did a couple trips, just the girlfriend and I, about 10 years ago where we made it for a decent stay at soundly under $1000 a person, and that feels like a pipe dream now. I also feel like the food situation's gotten weird; while I'm sure some of it is the nostalgia speaking, I do think there's a notable difference in quality between the old "in-house" prepared food versus today's contracted stuff.
But that's not even the biggest part to me; trips to Disney have always been expensive, that's a joke that runs back decades. The biggest issue today is that if you're going to ask people to spend insane money to attend, then you need to offer a product unlike anything else anyone else can produce; you need to transport people to a place and state of mind they can't find anywhere else, you need to have the "Disney Difference" that used to be such a big deal. But unfortunately, since Iger took the reins and since the "Post-Potter Reaction" era, Disney, to me at least, has lost sight of what makes a theme park really tick, and instead has been trying too hard to match the Potterverse stuff by aping the IP land style.
Yeah, I know, "IP bad" is the most lukewarm of takes right now, but I genuinely think it's an approach with diminishing returns; at both Disney and Universal, we've seen big IP lands open in recent years, trigger big attendance boosts for a year or two, then seen numbers dip again. And while people will still clamor to see their favorite characters everywhere, I'm beginning to think they're subconsciously realizing that "let's shoehorn this movie into this space" does a lot to undo the cohesion and, yes, theming of a park, and it's leading to people no longer feeling whisked away by a large, consistent space that manages to not just give you a quick thrill, but feel like an environment you want to spend a lot of time in, and are willing to pay good money to do so.
I think the feeling jumped out at me while walking in Studios the other day and seeing the "transition", such as it is, between Galaxy's Edge and Toy Story Land. Like...what are we doing here? What's the theme of this park? What am I supposed to be immersed in? Once you make me lose sight of that, I start focusing instead on just how many gift shops there are, how often I feel like something is aiming for my wallet, that sort of thing, whereas in old Disney I'd be more likely to just happily pay for whatever because, hey, no other place like it, right? And I'm not even getting into how many 10+ minute attractions we've lost for 2-3 minute ones that just dump you into another shop...holy smokes, I really don't have much good to say about Remy's Adventure in EPCOT, though at least that wasn't a replacement.
I'm not saying the feeling doesn't exist anywhere in Disney anymore, but it's mostly concentrated in the older Imagineered spaces; old school MK, World Showcase, front half of Studios, the fleshed out parts of AK, etc. And hey, at least some of the IP lands are trying; you can tell the effort that went into something like Pandora, even if I think it's just so-so as an experience.
But end of the day, people will become repeat visitors because they're being transported somewhere physically, mentally, and emotionally. You can grab their attention with "here's that familiar movie/character you know!", but it's the spatial experience that creates an indelible mark, and in the chase to keep up with Potter, I feel like current Disney's lost the plot and just expects people to keep ponying up more and more to hit up their favorite rides, which can work...but only up to a point.