I've noticed that In-and-Out Burger seems to have a more devoted fan base than I would expect for a burger and fries joint. They're not in my area of the country, so I can't just go out and try it. But I will visit California again some day. Convince me why I should stop there, especially for someone who really tries to avoid fast food whenever possible.
A function of time, place, and nostalgia.
In n Out was a Cali region favorite that established themselves for standout quality, strict adherence to being on brand, stoking a bit of nostalgia, and building a local following with gimmicks like the hidden menu. They established themselves in Cali, and by resisting expansion, it became kind of a 'cali only' thing locals attached to as 'theirs'. This was before boutique and gourmet burgers were all the rage everywhere else. This made it kind of a 'destination thing' to do when in Cali and the legend grew. They eventually grew through the southwest and into Texas... but again kept themselves more of an exclusive... and differentiated themselves from the Wendys/McDonalds/BKs that dominated the scene. They built their following that way. It was a combination of 'unique'+quality promise+service differentiators... boosted by a possessive cali culture. A great product strategy. They are also well respected in their markets for their approach towards employees and community. So they are a liked brand.. instead of an evil corp.
Now the the prime menu differentiators they used to stand out... fresh toppings, quality unfrozen meat, and diverse menus have been duplicated all over the place with other gourmet burger chains. The market is flooded with chains that try to offer a premium burger. So someone who has had Five Guys, Smashburger, Whataburger, Fosters, or any other of the 3 dozen plus burger specialty places at their doorstep for the last 10+ years goes into a In n Out Burger for the first time and goes 'meh... good but not a standout' simply because they have no attachment to the aurora around it or see it as much of a unique offer because they are surrounded by 'like products' all over now.
Still a great product and good company - but one whose product differentiators have been hacked away at by other more boutique burger brands now. Anyone who wants a specialty burger likely has multiple options now... not just 'fresh vs fast food'
As to why someone should go there... it's meant to be a throwback to service and a quality, fresh product. They make a great burger and have classic shoestring fries.