I honestly think Star Wars Land is a perfect storm of every single criteria you mentioned. Sure it's a guaranteed money maker, but you don't think the gang at WDI who grew up on Star Wars wasn't drooling at the chance to go crazy building an entire world based on the franchise?
To me, it's one of those no-brainer "how do they NOT do this??" deals. Star Wars has been ingrained into Disney culture for half as long as Disneyland has been in existence with Star Tours attractions around the world, Jedi Training Academy, Star Wars weekends, Star Wars marathon, etc. There are now multiple generations who have grown up associating Star Wars with Disney. If you don't think of Star Wars as a Disney thing, you are simply getting hung up over semantics.
IMO, it is the only franchise truly worthy of its own land -- something that could stand the test of time. By the time the land opens, we will be in the middle of a THIRD trilogy along with new movies exploring and creating backstories for other characters. Along with books, comic books, live action/animated tv, video games, and so on. It is a very, very different beast from The Wizarding World of Harry Potter which is based on a story that really revolves around one central character -- heck, even his name is in the land's name! In 10 years, it is entirely possible interest will have waned on the Harry Potter franchise and then what?
The closest thing the world had to a 'franchise' when Disney opened was Disney itself and we saw that manifest in the form of Fantasyland. In my eyes, Fantasyland WAS and IS the Disney Land of Disneyland. It is all things Disney brought to life. This is what Star Wars Land is. It's not a section of the park that revolves around one character or one story. It is literally the universe of Star Wars brought to life in a themed environment -- something that so many of us have been dreaming to experience since we were in diapers playing with action figures. If someone's biggest issue with it is it being a land dedicated to one IP versus multiple, again, I think you are getting hung up on semantics.
I can not tell you how pumped I am on it.
If I may interject, I don't think IP alone is what makes a land "lasting". It's far more nuanced than that.
Batman is a 50+ year franchise with equally impressive publishing and media credentials, yet...nothing has been done with it that is very good. A few roller coasters (ok, I only know of the one here in Six Flags over GA, but I'm sure there are others and I don't want to go googling)...
The thing that Walt hit upon that no other theme park really has done right, aside from Universal, is environment.
I want to go back to the Harry Potter experiences at Uni Florida for one reason. Immersion. It's truly a unique experience, with details everywhere...from the shop windows to even the rides themselves (with the exception of Dualing Dragons, which really is a just a thrill ride with little immersion). Every time I visit there (which has been 3 times) I notice something new I didn't see before (even if it was always there). This is what makes for excellent theme park design, and "lasting" attractions. In 10 years, kids may not remember Harry Potter, but their now 20 - 30 something parents will...and they've created a world there that brings them back to their own childhood, and encourages them to share it with their children.
I'd say it's quite lasting.
Star Wars could be done extremely well (I suspect it will be), but the IP alone doesn't justify anything. It's what they do with it.
Avatar is another example. A defense for Avatarland, in my book, isn't "look how much money it made"...reflective reviews done later by many people, and in fact the general consensus I've witnessed, is that most people do grant it's a rather shallow plot that relies on effects more than story. BUT, if done well, it can still make for a fantastic theme park experience that stands on its own.
Frankly, it's a full circle arguement. If you build the world first, you can later tell stories within it (that is what POTC is, and why POTC is still epic to this day as both a ride and a movie series, but, more as a ride)...and that is part of what Walt did. Yeah, there were IPs here and there, but it was also the novelty of experiencing an EVIRONMENT that was unique and largely detached from the outside world, yet still familiar in some way.
Star Wars Land will be a smash when it opens, but the question is...like Star Tours did, will people grow less fond of it as time moves on and the flash dissipates? Will it still command long lines for it's rides like non-IP based attractions that have become classics? This is the balancing act Disney walks, and what WDI is supposed to be all about (walking that line from the quick IP smash and grab designs to lasting designs that attract for decades)...