the math is pretty simple for the DDP.
Using 2019 pricing, the DDP for adults was $75.49
Dinner: Crystal Palace ~$50 adult beverage ~$10
Lunch: Star Lite Cafe - Grilled Chicken Club - $11.99 ~ Soft Drink $3
Snack #1 - Mickey Pretzel $7.50
Snack #2 - Churro $5 (or a coffee from Starbucks)
Total: $87.49
unlisted: cost of refillable mug and any beverages you use it for
Obviously your family would need to enjoy this type of food and these experiences. If you do not like eating sit down meals, or only like to eat light - then the DDP is not for you because it's a waste. Back then breakfast was cheaper than dinner so you were more forced to do lunch/dinner for "value" but currently, using Crystal Palace as an example all meals have the same price range. However you're probably not grabbing a beer at breakfast - but no judging if you do!
Some places allow cocktails as a sub for beer and wine and your value increases at that point. There are also more expensive lunches and snacks you could find to increase value too. Some of SWGE lunch QS meals were in the $14-16 range.
So even if I purchased the DDP outright, the cost was basically the same out of pocket. However, the free dining offer for me was a value of $176.34 a day (family of 5) and with paying for the upgrade from QSDP to DDP my total value on the deal was $118.34 a day which was about 5x the amount of savings as a room discount.
Of course you could eat peanut butter sandwhiches all day and drink from water fountains and you would look at me like I'm crazy on spending that much on food. Or you could think I'm dumb by giving my kids an awesome experience at Disney World having dinner every night with some of their favorite characters. And when you inevitably do, I'm going to shrug my shoulders at you and I say you do you.
Now not using a character meal in today's prices using Tonys Town Square - a dinner would cost you $27-36, Dessert $9, Drink is $3.50? Even in today's pricing a normal sit down meal is $10 cheaper than a character meal so back in 2019 the you were still having a tough time breaking even but it was close.
But that is ancient history. Going forward, with the loss of a snack, the DDP its going to be a challenge to find value unless they reduce the price or at least keep it the same.
My own personal experience with three kids under 8 in 2019? We did character meals every day which we all loved. We loved being able to sit down for an hour or so, eat, with the kids being entertained with the characters and relax in the air conditioning. I was there on a free dining promo - so even if I lost money on food each day (I didn't) the few extra dollar I did lose was well worth the cost of the experience I gained from it.