My theory is that some of the downward price movements that began in 2008 were a direct result of the "great recession". People who already owned lost jobs and had to sell combined with less people renting points. Disney stopped aggressively buying through ROFR because they didn't want to be stuck with a lot of excess inventory.
I agree the economy was one of the big factors which contributed to resale declines. Not so sure about ROFR. ROFR has always been spotty and inexplicable. Even without a threat of ROFR in the pre-2008 resale market, I'm not convinced that sellers would have lowered their asking prices dramatically.
IMO the other big factor was simply an overvaluing of older resorts...particularly in the 2005-2007 timeframe.
From late 2003 through 2006 the ONLY resort that DVC actively marketed was Saratoga Springs. Then Animal Kingdom was added in 2007 to late 2008. And while both have their fans, neither resort set the marketplace on fire. They both lack a close proximity to a theme park. And both are dramatically larger than other popular destinations, making them easier to book at 7 months.
In that 2005-2007 timeframe, resale buyers overvalued the likes of BoardWalk, Beach Club and Wilderness Lodge. The 2042 ending dates of those resorts gave buyers 30-40% less time on their contract than a purchase at SSR or AKV. Yet, resale prices for BCV, BWV and VWL circa 2007 were within a few dollars of DVC's direct prices for SSR and AKV.
Then came Bay Lake Tower. And Grand Californian, perhaps to a lesser degree.
Suddenly buyers seeking that "close to a theme park" destination could get a contract 18 YEARS longer than BCV, BWV or VWL. And thanks to the 2008 / 2009 economy, early Bay Lake Tower prices were pretty darn attractive.
So you had the double whammy of an economy that dumped a lot of points on the resale market PLUS the "hot" resale destinations (BWV, BCV, VWL) were no longer hot anymore with new competition from BLT and VGC.
Continued ROFR wouldn't have helped because there simply weren't enough buyers looking to purchase 33-34 years of BCV at $90+ per point when they could get 50 years of BLT or VGC for $95-100 per point. IMO, the resale prices we see today aren't the result of a depressed marketplace. Instead they are a better indicator of what 30 years' of ownership should actually buy.