Star Tours is interesting for many reasons. It’s the easiest ride to use as a promotion for new Star Wars content since it is in DLR, WDW, DLP, and TDR and it’s relatively easy to add new sequences.
It’s also currently the only attraction where guests can see beloved characters like Darth Vader, Princess Leia, or the Mandalorian. Until Disney finds a way to add these characters to Galaxy’s Edge, I think Star Tours has a home.
Studios ALSO has much bigger fish to fry in terms of replacements. Animation Courtyard is ripe for replacement (either Monsters or something else entirely). RnRC is getting more dated every day. Beauty and Indy aren’t the draws they once were, especially with those franchises represented in other parks. I think that’ll keep Star Tours around for a while longer.
The only way I see Star Tours disappearing is if Disney needs a cheap easy overlay and they can clone something for some of the other Star Tours around the world. Basically I think Disneyland’s Tomorrowland revamp is our best chance at seeing Star Tours replaced.