Well, I would stay on site at an all star before staying off site. But we have kids and the inconvience of being off site is not worth the upscale hotels off site. Besides we are rarely in our rooms except for naps and bedtime! The Disney theme is great through out the all stars and we love the fact that we dont have to lug around that special stuffed animal, t-shirt etc! Buy it and its sent to your room waiting for you! But just like everything else its a matter of choice. If they have kids I would stay on site, no kids, dont mind the hassle of driving, parking, etc then stay off site. But we go on other trips so when we get to Orlando its onsite the whole time..even if we aren't going to Disney every day! Just because we love the Disney magic~ just wish the still had the EE!