Mine is a toss up. I love going around Halloween time b/c of MNSSHP, but the beginning of December, is my far my favorite, there is just something about Disney around the holidays that I can't get enough of!
I like May or October
I've found that mid september is the best for us... nice weather (usually) and the crowds are about a light as they get.
Register on WDWMAGIC. This sidebar will go away, and you'll see fewer ads.