Pin trading at WDW is purely for fun. My kids don't "collect". Except that they'd look for characters they liked.
As to being polite to adults, its the "job" of parents to teach children manners. That failure is a direct reflection of the parents deficiency, not necessarily the children's.